Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf_security: Fix data cache buffer size in Cracen #19827

Merged
merged 1 commit into from
Jan 10, 2025
Merged

nrf_security: Fix data cache buffer size in Cracen #19827

merged 1 commit into from
Jan 10, 2025

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Jan 9, 2025

The input variable in the function sx_blkcipher_ecb_simple is a pointer and not an array. So sizeof cannot be used to determine the array size. Replace this with the input_size variable which contains the correct iput size of the buffer.

@Vge0rge
nrf_security: Fix data cache buffer size in Cracen
e7ec5b7 
The input variable in the function sx_blkcipher_ecb_simple
is a pointer and not an array. So sizeof cannot be used to
determine the array size. Replace this with the input_size
variable which contains the correct iput size of the buffer.

Signed-off-by: Georgios Vasilakis <[email protected]>
@Vge0rge Vge0rge requested a review from a team as a code owner January 9, 2025 15:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: e7ec5b7903f96bda4b91e5cf2e141d2b1d69b786

more details

sdk-nrf:

PR head: e7ec5b7903f96bda4b91e5cf2e141d2b1d69b786
merge base: 8cc2355b999aa77b56e5d08e582e99ebd4fe2569
target head (main): 315b706c7d27c7b2bfebdee36f8772a6a3b899d5
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  ├── cracen
│  │  │  │  │  ├── sxsymcrypt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ blkcipher.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1641
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-sdk-find-my
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

tomi-font
tomi-font approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tomi-font tomi-font left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 (BTW it also wouldn't work even if input were declared as an array in the function parameters, sizeof() still returns the size of the pointer in that case.)

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Jan 10, 2025

😮 (BTW it also wouldn't work even if input were declared as an array in the function parameters, sizeof() still returns the size of the pointer in that case.)

You are right of course, if it is a function parameter and not a local array it returns the pointer size.

@rlubos rlubos merged commit fd398f0 into nrfconnect:main Jan 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi-font tomi-font tomi-font approved these changes

@degjorva degjorva degjorva approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vge0rge @NordicBuilder @degjorva @tomi-font @rlubos